[PATCH] D49095: [COFF] Store a pointer to the parent instead of just the parent name in InputFile

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 15:14:55 PDT 2018


ruiu added a comment.

I think it is a lack of an appropriate test. I believe we construct an error message at runtime by concatenating archive file name with a object file name, so if we handle object files in an /wholearchive archive file as if they are outside of any archive, we'd generate a wrong error message.

There's no strong reason not to instantiate archive files for /wholearchive. It's just that it's currently a (small) waste of resource.


https://reviews.llvm.org/D49095





More information about the llvm-commits mailing list