[PATCH] D48988: Debug prefix map for machine code emission

[Siddhartha Bagaria via Phabricator via llvm-commits]

starsid added inline comments.


================
Comment at: include/llvm/MC/MCContext.h:497
+    /// Get the debug prefix map.
+    const std::map<const std::string, const std::string> &getDebugPrefixMap() const {
+      return DebugPrefixMap;
----------------
probinson wrote:
> This looks longer than 80 columns.  clang-format-diff will fix this kind of thing for you.
> Or use a typedef for the map.
Oh I did not know about clang-format-diff. Thank you.

It could be useful to configure clang-format as a linter for arcanist, if most people use arcanist for code reviews. I can send in a patch for that if you want.

We started using 100 as the line length limit in my organization, so I tend to not notice the 80 column violations anymore. Thank you for pointing these out.


Repository:
  rL LLVM

https://reviews.llvm.org/D48988