[PATCH] D47541: Allow creating llvm::Function in non-zero address spaces

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 10:56:13 PDT 2018


bjope added inline comments.


================
Comment at: test/Bitcode/function-address-space-fwd-decl.ll:6
+entry:
+  %0 = tail call addrspace(40) i32 @llvm.phx.aload(i16* null)
+  ; CHECK: %0 = tail call addrspace(40) i32 @llvm.phx.aload(i16* null)
----------------
Please call this `@bar` (or something) instead of `@llvm.phx.aload`.
(I should probably have done that in the example I gave you earlier, because I prefer if this doesn't match with the name of an intrinsic in our out-of-tree target).


Repository:
  rL LLVM

https://reviews.llvm.org/D47541





More information about the llvm-commits mailing list