[PATCH] D49040: [SLC] Simplify pow(x, 0.333...) to cbrt(x)

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 10:48:57 PDT 2018


evandro added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1138-1139
+
+  const APFloat SPPlusThird(1.0f / 3.0f), SPMinusThird(-1.0f / 3.0f),
+                DPPlusThird(1.0  / 3.0),  DPMinusThird(-1.0  / 3.0);
+  bool isPlusThird  = Arg2C->isExactlyValue((TyID == Type::FloatTyID)
----------------
lebedev.ri wrote:
> There seems to be two variants: https://godbolt.org/g/Rw1Gxt
> Can you output the value that doesn't match?
Please, see any example using `float` in the test case below.


https://reviews.llvm.org/D49040





More information about the llvm-commits mailing list