[PATCH] D49087: [WebAssembly] Improve readability of load/stores and tests. NFC.

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 10:41:59 PDT 2018


aheejin updated this revision to Diff 154640.
aheejin added a comment.

- Pattern name change: anyext_aload -> sext_aload

This pattern doesn't cover all the sign extension selection (we need a
sext_inreg after that), but it looks less confusing and more consistent with
zext_aload patterns. And we gave enough explanations in comments anyway.


Repository:
  rL LLVM

https://reviews.llvm.org/D49087

Files:
  lib/Target/WebAssembly/WebAssemblyInstrAtomics.td
  lib/Target/WebAssembly/WebAssemblyInstrMemory.td
  test/CodeGen/WebAssembly/i32-load-store-alignment.ll
  test/CodeGen/WebAssembly/i64-load-store-alignment.ll
  test/CodeGen/WebAssembly/offset-atomics.ll
  test/CodeGen/WebAssembly/offset.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49087.154640.patch
Type: text/x-patch
Size: 75234 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180709/9b5e203b/attachment.bin>


More information about the llvm-commits mailing list