[PATCH] D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides.

[Siddharth via Phabricator via llvm-commits]

bollu added inline comments.


================
Comment at: lib/Analysis/ScopBuilder.cpp:757
+  // a Shape object. So, do that first.
+  addArrayAccess(Stmt, Inst, AccType, BasePtr, ElementType, /*IsAffine=*/true,
+                 Subscripts, ShapeInfo::fromStrides(Strides, OffsetSCEV), Val);
----------------
@cs15btech11044, Here is where we add an array access from the `Subscripts` that we have derived.

If we derive `Subscripts` incorrectly, we will record an incorrect array shape (and possibly an incorrect array index).

Here is where the "link" between our "intrinsic" and Polly's array modelling happens.


Repository:
  rPLO Polly

https://reviews.llvm.org/D49024