[PATCH] D49056: [Dominators] Add isUpdateLazy() method to the DomTreeUpdater

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 08:29:25 PDT 2018


kuhar added a comment.

Perhaps it would make sense to expose a similar function for the Eager strategy?
And I would make it sorter, so just `isLazy` and `isEager` -- shouldn't make anything more ambiguous IMO.



================
Comment at: include/llvm/IR/DomTreeUpdater.h:49
 
-  /// Returns the UpdateStrategy of the class instance.
-  UpdateStrategy getUpdateStrategy() const { return Strategy; };
+  /// Returns true if the class instance works under the Lazy UpdateStrategy.
+  bool isUpdateLazy() const { return Strategy == UpdateStrategy::Lazy; };
----------------
Maybe something shorter would also fit here, like:
`// Returns true if the current strategy is Lazy.`?


Repository:
  rL LLVM

https://reviews.llvm.org/D49056





More information about the llvm-commits mailing list