[PATCH] D45383: Limit types of builtins that can be redeclared.

Erich Keane via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 06:27:08 PDT 2018


erichkeane added a comment.

I'm curious why that file is declaring the builtin like that?  The declaration doesn't seem like it is ever useful, builtins are available without any includes/etc as far back as I could go on all 3 compilers that I validated against.

Additionally, I believe that the declaration is actually prohibited by the standard, since it is declaring an identifier that is reserved for the implementation.

Is this a situation where the target project cannot be corrected? That line simply needs to be removed as far as I can tell.


Repository:
  rL LLVM

https://reviews.llvm.org/D45383





More information about the llvm-commits mailing list