[PATCH] D45556: [DebugInfo] Generate DWARF debug information for labels.

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1261
+  // Collect info for variables/labels that were optimized out.
   for (const DINode *DN : SP->getRetainedNodes()) {
     if (auto *DV = dyn_cast<DILocalVariable>(DN)) {
----------------
aprantl wrote:
> ```
>   if (auto *DV = dyn_cast<DILocalVariable>(DN)) {
>       if (!Processed.insert(InlinedVariable(DV, nullptr)).second)
>         continue;
>   if (LexicalScope *Scope = LScopes.findLexicalScope(DN->getScope()))
>      createConcreteEntity(TheCU, *Scope, DN, nullptr);
> ```
> ?
There is no apparent default version of getScope() in DINode. So, I could not merge these two code fragments into one.


Repository:
  rL LLVM

https://reviews.llvm.org/D45556