[PATCH] D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides.

[Siddharth via Phabricator via llvm-commits]

bollu added inline comments.


================
Comment at: lib/Analysis/ScopBuilder.cpp:752
+      isa<LoadInst>(Inst) ? MemoryAccess::READ : MemoryAccess::MUST_WRITE;
+  scop->invalidate(DELINEARIZATION, Inst->getDebugLoc(), Inst->getParent());
+
----------------
cs15btech11044 wrote:
> @Bollu. I am talking about this line here
Yeah, this looks like dead code that was left out. If you remove the line, then what happens? 


##### Regarding Invalidate Scop

You mentioned that you get this error:

> `Invalidate SCoP because of reason 9`

So, the reasons for invalidation are listed in this enum

```cpp
enum AssumptionKind {
  ALIASING,
  INBOUNDS,
  WRAPPING,
  UNSIGNED,
  PROFITABLE,
  ERRORBLOCK,
  COMPLEXITY,
  INFINITELOOP,
  INVARIANTLOAD,
  DELINEARIZATION,
};
```

this is in `include/polly/ScopInfo.h:98`

Since `DELINEARIZATION` has enum value 10, it means that it someone called 

```lang=cpp
invalidateScop(..., DELINERALIZATION, ....)
```

Which is the line you are pointing at. Removing this line should solve the problem.


https://reviews.llvm.org/D49024