[PATCH] D49030: Add OrderedSet, with constant-time insertion and removal, and random access iteration.

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 7 06:32:23 PDT 2018


labrinea added a comment.

In https://reviews.llvm.org/D49030#1155000, @chandlerc wrote:

> We already have SetVector which is widely used for these patterns. If we need both, we need a clear explanation of the difference and why we need both (IE, why users of one can't use the other).


The remove operation on a SetVector can cost linear time and this might be an issue in some cases. Please have a look at the review comments of https://reviews.llvm.org/D48372


https://reviews.llvm.org/D49030





More information about the llvm-commits mailing list