[PATCH] D48817: [LoopInfo] Port loop exit interfaces from Loop to LoopBase

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.

Minor cleanups, and then this should be good.

BTW, do you have commit access?



================
Comment at: include/llvm/Analysis/LoopInfoImpl.h:85-86
 
+/// hasDedicatedExits - Return true if no exit block for the loop has a
+/// predecessor that is outside the loop.
+template <class BlockT, class LoopT>
----------------
Delete - this is a stale doxygen commment, and the API is documented in the header.


================
Comment at: include/llvm/Analysis/LoopInfoImpl.h:101-104
+/// getUniqueExitBlocks - Return all unique successor blocks of this loop. These
+/// are the blocks _outside of the current loop_ which are branched to. This
+/// assumes that loop exits are in canonical form, i.e. all exits are dedicated
+/// exits.
----------------
Delete, same as above.


================
Comment at: include/llvm/Analysis/LoopInfoImpl.h:150-151
+
+/// getUniqueExitBlock - If getUniqueExitBlocks would return exactly one block,
+/// return that block. Otherwise return null.
+template <class BlockT, class LoopT>
----------------
Delete, same as above.


Repository:
  rL LLVM

https://reviews.llvm.org/D48817