[PATCH] D49039: [BitcodeReader] Infer the correct runtime preemption for GlobalValue

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 6 15:18:16 PDT 2018


steven_wu added a comment.

In https://reviews.llvm.org/D49039#1154801, @vsk wrote:

> Thanks for doing this!
>
> Could you add a test? Adding "opt -verify <old-bitcode-file>" run lines to the compatibility tests would be fine.


You will be surprise how many things will break if you run verifier on old bitcode file. The first error you will hit is not about dso_local: Global is marked as dllimport, but not external


Repository:
  rL LLVM

https://reviews.llvm.org/D49039





More information about the llvm-commits mailing list