[PATCH] D49031: [AccelTable] Extract EmitterInfo

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/AccelTable.h:290
 
+class AccelTableEmitterInfo {
+public:
----------------
Doxygen comment?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp:238
+
+class DefaultAccelTableEmitterInfo final : public AccelTableEmitterInfo {
+private:
----------------
Doxygen comment for the class?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp:453
+  }
+#if 0
   for (const auto &CU : enumerate(CompUnits)) {
----------------
The LLVM coding guidelines discourage commented out code. Is this necessary here?


Repository:
  rL LLVM

https://reviews.llvm.org/D49031