[llvm] r336336 - Partially revert r336268 in address-offsets.ll

Richard Smith via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 21:11:00 PDT 2018


It would seem wise to change this test to use a more obvious way to disable
the CHECK lines, such as by replacing CHECK with DISABLED instead of adding
a space in the middle of the -NEXT, so that another enthusiastic janitor is
less likely to remove the spaces again.

On Thu, 5 Jul 2018 at 04:30, Krasimir Georgiev via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: krasimir
> Date: Thu Jul  5 04:30:15 2018
> New Revision: 336336
>
> URL: http://llvm.org/viewvc/llvm-project?rev=336336&view=rev
> Log:
> Partially revert r336268 in address-offsets.ll
>
> Summary: There the typos are intentional, explicitly introduced to disable
> these cases in r280285.
>
> Reviewers: bkramer
>
> Reviewed By: bkramer
>
> Subscribers: dschuff, sbc100, jgravelle-google, aheejin, llvm-commits
>
> Differential Revision: https://reviews.llvm.org/D48962
>
> Modified:
>     llvm/trunk/test/CodeGen/WebAssembly/address-offsets.ll
>
> Modified: llvm/trunk/test/CodeGen/WebAssembly/address-offsets.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/address-offsets.ll?rev=336336&r1=336335&r2=336336&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/WebAssembly/address-offsets.ll (original)
> +++ llvm/trunk/test/CodeGen/WebAssembly/address-offsets.ll Thu Jul  5
> 04:30:15 2018
> @@ -36,9 +36,9 @@ define i32 @load_test0_noinbounds() {
>  ; CHECK-NEXT: param     i32{{$}}
>  ; CHECK-NEXT: result    i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
> -; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.load  $push2=, g+40($pop1){{$}}
> -; CHECK-NEXT: return    $pop2{{$}}
> +; CHECK-NEX T: i32.shl   $push1=, $0, $pop0{{$}}
> +; CHECK-NEX T: i32.load  $push2=, g+40($pop1){{$}}
> +; CHECK-NEX T: return    $pop2{{$}}
>  define i32 @load_test1(i32 %n) {
>    %add = add nsw i32 %n, 10
>    %arrayidx = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %add
> @@ -50,9 +50,9 @@ define i32 @load_test1(i32 %n) {
>  ; CHECK-NEXT: param     i32{{$}}
>  ; CHECK-NEXT: result    i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
> -; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.load  $push2=, g+40($pop1){{$}}
> -; CHECK-NEXT: return    $pop2{{$}}
> +; CHECK-NEX T: i32.shl   $push1=, $0, $pop0{{$}}
> +; CHECK-NEX T: i32.load  $push2=, g+40($pop1){{$}}
> +; CHECK-NEX T: return    $pop2{{$}}
>  define i32 @load_test2(i32 %n) {
>    %add = add nsw i32 10, %n
>    %arrayidx = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %add
> @@ -64,9 +64,9 @@ define i32 @load_test2(i32 %n) {
>  ; CHECK-NEXT: param     i32{{$}}
>  ; CHECK-NEXT: result    i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
> -; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.load  $push2=, g+40($pop1){{$}}
> -; CHECK-NEXT: return    $pop2{{$}}
> +; CHECK-NEX T: i32.shl   $push1=, $0, $pop0{{$}}
> +; CHECK-NEX T: i32.load  $push2=, g+40($pop1){{$}}
> +; CHECK-NEX T: return    $pop2{{$}}
>  define i32 @load_test3(i32 %n) {
>    %add.ptr = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %n
>    %add.ptr1 = getelementptr inbounds i32, i32* %add.ptr, i32 10
> @@ -78,9 +78,9 @@ define i32 @load_test3(i32 %n) {
>  ; CHECK-NEXT: param     i32{{$}}
>  ; CHECK-NEXT: result    i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
> -; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.load  $push2=, g+40($pop1){{$}}
> -; CHECK-NEXT: return    $pop2{{$}}
> +; CHECK-NEX T: i32.shl   $push1=, $0, $pop0{{$}}
> +; CHECK-NEX T: i32.load  $push2=, g+40($pop1){{$}}
> +; CHECK-NEX T: return    $pop2{{$}}
>  define i32 @load_test4(i32 %n) {
>    %add.ptr = getelementptr inbounds i32, i32* getelementptr inbounds ([0
> x i32], [0 x i32]* @g, i32 0, i32 10), i32 %n
>    %t = load i32, i32* %add.ptr, align 4
> @@ -91,9 +91,9 @@ define i32 @load_test4(i32 %n) {
>  ; CHECK-NEXT: param     i32{{$}}
>  ; CHECK-NEXT: result    i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
> -; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.load  $push2=, g+40($pop1){{$}}
> -; CHECK-NEXT: return    $pop2{{$}}
> +; CHECK-NEX T: i32.shl   $push1=, $0, $pop0{{$}}
> +; CHECK-NEX T: i32.load  $push2=, g+40($pop1){{$}}
> +; CHECK-NEX T: return    $pop2{{$}}
>  define i32 @load_test5(i32 %n) {
>    %add.ptr = getelementptr inbounds i32, i32* getelementptr inbounds ([0
> x i32], [0 x i32]* @g, i32 0, i32 10), i32 %n
>    %t = load i32, i32* %add.ptr, align 4
> @@ -104,9 +104,9 @@ define i32 @load_test5(i32 %n) {
>  ; CHECK-NEXT: param     i32{{$}}
>  ; CHECK-NEXT: result    i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
> -; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.load  $push2=, g+40($pop1){{$}}
> -; CHECK-NEXT: return    $pop2{{$}}
> +; CHECK-NEX T: i32.shl   $push1=, $0, $pop0{{$}}
> +; CHECK-NEX T: i32.load  $push2=, g+40($pop1){{$}}
> +; CHECK-NEX T: return    $pop2{{$}}
>  define i32 @load_test6(i32 %n) {
>    %add = add nsw i32 %n, 10
>    %add.ptr = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %add
> @@ -118,9 +118,9 @@ define i32 @load_test6(i32 %n) {
>  ; CHECK-NEXT: param     i32{{$}}
>  ; CHECK-NEXT: result    i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
> -; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.load  $push2=, g+40($pop1){{$}}
> -; CHECK-NEXT: return    $pop2{{$}}
> +; CHECK-NEX T: i32.shl   $push1=, $0, $pop0{{$}}
> +; CHECK-NEX T: i32.load  $push2=, g+40($pop1){{$}}
> +; CHECK-NEX T: return    $pop2{{$}}
>  define i32 @load_test7(i32 %n) {
>    %add.ptr = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %n
>    %add.ptr1 = getelementptr inbounds i32, i32* %add.ptr, i32 10
> @@ -132,9 +132,9 @@ define i32 @load_test7(i32 %n) {
>  ; CHECK-NEXT: param     i32{{$}}
>  ; CHECK-NEXT: result    i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
> -; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.load  $push2=, g+40($pop1){{$}}
> -; CHECK-NEXT: return    $pop2{{$}}
> +; CHECK-NEX T: i32.shl   $push1=, $0, $pop0{{$}}
> +; CHECK-NEX T: i32.load  $push2=, g+40($pop1){{$}}
> +; CHECK-NEX T: return    $pop2{{$}}
>  define i32 @load_test8(i32 %n) {
>    %add = add nsw i32 10, %n
>    %add.ptr = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %add
> @@ -378,8 +378,8 @@ define void @store_test0_noinbounds(i32
>  ; CHECK-NEXT: param     i32, i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
>  ; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.store g+40($pop1), $1{{$}}
> -; CHECK-NEXT: return{{$}}
> +; CHECK-NEX T: i32.store g+40($pop1), $1{{$}}
> +; CHECK-NEX T: return{{$}}
>  define void @store_test1(i32 %n, i32 %i) {
>    %add = add nsw i32 %n, 10
>    %arrayidx = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %add
> @@ -391,8 +391,8 @@ define void @store_test1(i32 %n, i32 %i)
>  ; CHECK-NEXT: param     i32, i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
>  ; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.store g+40($pop1), $1{{$}}
> -; CHECK-NEXT: return{{$}}
> +; CHECK-NEX T: i32.store g+40($pop1), $1{{$}}
> +; CHECK-NEX T: return{{$}}
>  define void @store_test2(i32 %n, i32 %i) {
>    %add = add nsw i32 10, %n
>    %arrayidx = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %add
> @@ -404,8 +404,8 @@ define void @store_test2(i32 %n, i32 %i)
>  ; CHECK-NEXT: param     i32, i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
>  ; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.store g+40($pop1), $1{{$}}
> -; CHECK-NEXT: return{{$}}
> +; CHECK-NEX T: i32.store g+40($pop1), $1{{$}}
> +; CHECK-NEX T: return{{$}}
>  define void @store_test3(i32 %n, i32 %i) {
>    %add.ptr = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %n
>    %add.ptr1 = getelementptr inbounds i32, i32* %add.ptr, i32 10
> @@ -417,8 +417,8 @@ define void @store_test3(i32 %n, i32 %i)
>  ; CHECK-NEXT: param     i32, i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
>  ; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.store g+40($pop1), $1{{$}}
> -; CHECK-NEXT: return{{$}}
> +; CHECK-NEX T: i32.store g+40($pop1), $1{{$}}
> +; CHECK-NEX T: return{{$}}
>  define void @store_test4(i32 %n, i32 %i) {
>    %add.ptr = getelementptr inbounds i32, i32* getelementptr inbounds ([0
> x i32], [0 x i32]* @g, i32 0, i32 10), i32 %n
>    store i32 %i, i32* %add.ptr, align 4
> @@ -429,8 +429,8 @@ define void @store_test4(i32 %n, i32 %i)
>  ; CHECK-NEXT: param     i32, i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
>  ; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.store g+40($pop1), $1{{$}}
> -; CHECK-NEXT: return{{$}}
> +; CHECK-NEX T: i32.store g+40($pop1), $1{{$}}
> +; CHECK-NEX T: return{{$}}
>  define void @store_test5(i32 %n, i32 %i) {
>    %add.ptr = getelementptr inbounds i32, i32* getelementptr inbounds ([0
> x i32], [0 x i32]* @g, i32 0, i32 10), i32 %n
>    store i32 %i, i32* %add.ptr, align 4
> @@ -441,8 +441,8 @@ define void @store_test5(i32 %n, i32 %i)
>  ; CHECK-NEXT: param     i32, i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
>  ; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.store g+40($pop1), $1{{$}}
> -; CHECK-NEXT: return{{$}}
> +; CHECK-NEX T: i32.store g+40($pop1), $1{{$}}
> +; CHECK-NEX T: return{{$}}
>  define void @store_test6(i32 %n, i32 %i) {
>    %add = add nsw i32 %n, 10
>    %add.ptr = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %add
> @@ -454,8 +454,8 @@ define void @store_test6(i32 %n, i32 %i)
>  ; CHECK-NEXT: param     i32, i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
>  ; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.store g+40($pop1), $1{{$}}
> -; CHECK-NEXT: return{{$}}
> +; CHECK-NEX T: i32.store g+40($pop1), $1{{$}}
> +; CHECK-NEX T: return{{$}}
>  define void @store_test7(i32 %n, i32 %i) {
>    %add.ptr = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %n
>    %add.ptr1 = getelementptr inbounds i32, i32* %add.ptr, i32 10
> @@ -467,8 +467,8 @@ define void @store_test7(i32 %n, i32 %i)
>  ; CHECK-NEXT: param     i32, i32{{$}}
>  ; CHECK-NEXT: i32.const $push0=, 2{{$}}
>  ; CHECK-NEXT: i32.shl   $push1=, $0, $pop0{{$}}
> -; CHECK-NEXT: i32.store g+40($pop1), $1{{$}}
> -; CHECK-NEXT: return{{$}}
> +; CHECK-NEX T: i32.store g+40($pop1), $1{{$}}
> +; CHECK-NEX T: return{{$}}
>  define void @store_test8(i32 %n, i32 %i) {
>    %add = add nsw i32 10, %n
>    %add.ptr = getelementptr inbounds [0 x i32], [0 x i32]* @g, i32 0, i32
> %add
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180705/e33b3a3e/attachment.html>


More information about the llvm-commits mailing list