[PATCH] D49004: [CodeGen] Emit more precise AssertZext/AssertSext nodes.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 18:32:11 PDT 2018


efriedma created this revision.
efriedma added reviewers: RKSimon, arsenm, t.p.northover.
Herald added subscribers: tpr, nhaehnle, wdng.

This is marginally helpful for removing redundant extensions, and it's easier to read, so it seems like an all-around win.  In the new test i8-phi-ext.ll, we used to emit an AssertSext i8; now we emit an AssertZext i2, which allows the extension of the return value to be eliminated.

Someone familiar with the AMDGPU backend should review the test change there; I'm not sure why this change makes a difference.  (We now emit an AssertZext i27 for the stack address.)


Repository:
  rL LLVM

https://reviews.llvm.org/D49004

Files:
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/Target/Hexagon/HexagonISelLowering.cpp
  test/CodeGen/AMDGPU/frame-index-elimination.ll
  test/CodeGen/Thumb/i8-phi-ext.ll
  test/CodeGen/X86/pr32282.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49004.154343.patch
Type: text/x-patch
Size: 4226 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180706/0cc08cfb/attachment.bin>


More information about the llvm-commits mailing list