[PATCH] D48502: Fix direct calls to __wrap_sym when it is relocated

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 12:26:07 PDT 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SymbolTable.cpp:211
+// This is needed for direct calls to __wrap_sym
+void SymbolTable::applyRelocationToWrappedSymbols() {
+  for (WrappedSymbol &W : WrappedSymbols) {
----------------
This function doesn't really apply relocations, so the name doesn't seem right. I'd name this `applySymbolWrapReloc`.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48502





More information about the llvm-commits mailing list