[PATCH] D48857: Also search BitcodeFiles for exclude-lib symbols

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added inline comments.


================
Comment at: ELF/Driver.cpp:1156
 
-  for (InputFile *File : ObjectFiles)
+  auto markSymbolsInFile = [&](InputFile *File) {
     if (!File->ArchiveName.empty())
----------------
ruiu wrote:
> We don't need to give a long descriptive name for a local variable whose scope is narrow. Also, in LLVM/lld, local variables must be in CamelCase. I'd name this just `Visit`.
> Also, in LLVM/lld, local variables must be in CamelCase. 

Given that this is a function-like object, I'd argue for lowerCamelCase here. 


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48857