[PATCH] D48939: CallGraph passes: iterate over all functions rather than just externally visible ones

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 11:26:44 PDT 2018


dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Analysis/CallGraphSCCPass.cpp:478-479
+
+      // If we've got all functions reachable from our chosen initial node,
+      // calculate the next node we need to search from now too.
+      if (CGI.isAtEnd()) {
----------------
You might add " before it's invalidated" or something to make it more clear why this is here.


Repository:
  rL LLVM

https://reviews.llvm.org/D48939





More information about the llvm-commits mailing list