[PATCH] D48980: [CostModel][X86] Add SREM/UREM general and constant costs (PR38056)

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 10:33:11 PDT 2018


ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.

LG with a nit



================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:270-275
+        Cost += getArithmeticInstrCost(Instruction::Mul, Ty, Op1Info, Op2Info,
+                                       TargetTransformInfo::OP_None,
+                                       TargetTransformInfo::OP_None);
+        Cost += getArithmeticInstrCost(Instruction::Sub, Ty, Op1Info, Op2Info,
+                                       TargetTransformInfo::OP_None,
+                                       TargetTransformInfo::OP_None);
----------------
You can drop 2 last arguments from these functions calls


Repository:
  rL LLVM

https://reviews.llvm.org/D48980





More information about the llvm-commits mailing list