[PATCH] D44564: [BasicAA] Use PhiValuesAnalysis if available when handling phi alias

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 06:48:09 PDT 2018


john.brawn updated this revision to Diff 154224.
john.brawn edited the summary of this revision.
john.brawn set the repository for this revision to rL LLVM.
john.brawn added a comment.

@brzycki pointed out to me a test case where we get a crash with this patch which turns out to be due to BasicAA using stale PhiValuesAnalysis results due to how the legacy pass manager handles pass dependencies. Updated this patch to fix that problem by marking BasicAA as not CFG-only.


Repository:
  rL LLVM

https://reviews.llvm.org/D44564

Files:
  include/llvm/Analysis/BasicAliasAnalysis.h
  lib/Analysis/BasicAliasAnalysis.cpp
  test/Analysis/BasicAA/invalidation.ll
  test/Analysis/BasicAA/phi-aa.ll
  test/Analysis/BasicAA/phi-values-usage.ll
  test/Other/opt-O2-pipeline.ll
  test/Other/opt-O3-pipeline.ll
  test/Other/opt-Os-pipeline.ll
  test/Transforms/SCCP/preserve-analysis.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44564.154224.patch
Type: text/x-patch
Size: 19570 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180705/8000e241/attachment.bin>


More information about the llvm-commits mailing list