[PATCH] D48538: Make __gcov_flush flush counters for all shared libraries

Marco Castelluccio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 06:05:41 PDT 2018


marco-c added a comment.

> - instrprof-shared-main-gcov-flush_no-writeout.c.gcov: lines 23, 26 and 30 should not be covered; lines 33 and 35 should not be covered (they are considered as uncoverable instead).

I've filed https://bugs.llvm.org/show_bug.cgi?id=38067. It's unrelated to the presence of shared libraries.

> - instrprof-dlopen-func{2,3}.c.gcov: the only line in the function should be covered once and not thrice

I've filed https://bugs.llvm.org/show_bug.cgi?id=38065, this one too is unrelated to the presence of shared libraries.

I've also filed https://bugs.llvm.org/show_bug.cgi?id=38066, about wrong line hit counts when exceptions are enabled.

I've tested the patch on our CI and it was working correctly. I'll land it shortly.


https://reviews.llvm.org/D48538





More information about the llvm-commits mailing list