[PATCH] D48949: [ELF][MIPS] Remove support for linking microMIPS 64-bit code

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Arch/MipsArchTree.cpp:79
+
   for (const FileFlags &F : Files.slice(1)) {
+    rejectMicroMips64(F);
----------------
atanasyan wrote:
> grimar wrote:
> > This seems to be easier just to check all the files and inline, maybe?
> > 
> > ```
> >  for (const FileFlags &F : Files) {
> >      if (Config->Is64 && F.Flags & EF_MIPS_MICROMIPS)
> >        error("linking microMIPS 64-bit files is unsupported: " + toString(F.File));
> > ...
> > ```
> > 
> > Up to you, though.
> The loop iterates through all input files except the first one because initial purpose of the loop was to to check compatibility between files and the first file used as a reference. That's why I have to write the checking code before and inside the loop. But I think we can iterate through all the files including the first one. In that case we check compatibility between the first file and itself, but it's not a problem.
> 
> I'm going to commit this patch as is (thanks for review) and after that refactor this code.
Yes, that is what I meant. Checking the first file with itself should not be a problem.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48949