[PATCH] D48949: [ELF][MIPS] Remove support for linking microMIPS 64-bit code

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 02:28:18 PDT 2018


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: ELF/Arch/MipsArchTree.cpp:79
+
   for (const FileFlags &F : Files.slice(1)) {
+    rejectMicroMips64(F);
----------------
This seems to be easier just to check all the files and inline, maybe?

```
 for (const FileFlags &F : Files) {
     if (Config->Is64 && F.Flags & EF_MIPS_MICROMIPS)
       error("linking microMIPS 64-bit files is unsupported: " + toString(F.File));
...
```

Up to you, though.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48949





More information about the llvm-commits mailing list