[PATCH] D48914: [PGOMemOPSize] Preserve the DominatorTree

Chijun Sima via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 00:06:17 PDT 2018


NutshellySima marked 2 inline comments as done.
NutshellySima added inline comments.


================
Comment at: lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp:346
 
-  BasicBlock *DefaultBB = SplitBlock(BB, MI);
+  BasicBlock *DefaultBB = SplitBlock(BB, MI, &DT);
   BasicBlock::iterator It(*MI);
----------------
dmgreen wrote:
> Why not use DTU for the whole thing ;)
SplitBlock currently only accepts DT. I'll take care of making these APIs consistent later.


https://reviews.llvm.org/D48914





More information about the llvm-commits mailing list