[PATCH] D48413: [llvm-objcopy] Add initial support for static libraries

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: test/tools/llvm-objcopy/basic-archive-copy.test:37
+# RUN: llvm-ar crsT %t.thin.a %t
+# RUN: llvm-objcopy %t.thin.a %t2.thin.a
+# RUN: cat %t.thin.a | FileCheck %s --check-prefix=VERIFY-THIN-ARCHIVE
----------------
alexshap wrote:
> alexshap wrote:
> > jhenderson wrote:
> > > jhenderson wrote:
> > > > Maybe worth checking that %t is the same as %t2?
> > > Have I missed something? I don't see this being done anywhere.
> > > 
> > > For clarity, since the comment has moved, I was referring to checking the object file in the thin archive.
> > because of the location of your comment i thought you were referring to comparing the archives, and that was added (please, have a look at the line 42, I'm kinda tired to be honest).  Comparing %t and %t2 doesn't provide value - it's already done in the test basic-copy.test, so I won't add it here, sorry.
> okay, %t and %t2 are not compared exactly like this in basic-copy.test, instead, readobj  + text matching is used there. i can add it here
line 8


Repository:
  rL LLVM

https://reviews.llvm.org/D48413