[PATCH] D48930: [InstCombine] Apply foldICmpUsingKnownBits to early bailout case

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 4 09:36:24 PDT 2018


mkazantsev added a comment.

The context is following: the patch https://reviews.llvm.org/rL336172 has broken this test, and I was asked to fix it. Basically I just restored the behavior that we used to have before this sinking. I would prefer to not introduce any new transforms to InstCombine without dire need because it is fragile, and I am not familiar with it well enough (in particular, I don't understand ordering of particular transforms in many places). So I've chosen a conservative approach (to restore old behavior).

However if you think that this approach is unacceptable, I can try to introduce a new transform and hope that it will not change behavior of other tests.


https://reviews.llvm.org/D48930





More information about the llvm-commits mailing list