[PATCH] D47540: [lld] Enable Visual Studio compatible output

Chris Jackson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 4 06:29:04 PDT 2018


chrisjackson updated this revision to Diff 154100.
chrisjackson added a comment.

There are several modifications to the code and lit test additions based
on the suggestions given. The default origin or source used to prefix any
diagnostics with no source code file is now stored in Driver and passed to 
ErrorHandler. There are methods to set and get the private member
'DiagnosticSourceDefault'. This is a StringRef initialised to "lld", resembling
the previous behaviour of ErrorHandler.LogName.

Several changes to comments were required to account for the new output
formatting, in InputSection for example. The lit tests have been modified:

- A bad relocation type resulting in an error.
- A bad relocation type resulting in a warning.
- An updated test against a duplicate symbol error.


https://reviews.llvm.org/D47540

Files:
  Common/ErrorHandler.cpp
  ELF/Driver.cpp
  ELF/Driver.h
  ELF/DriverUtils.cpp
  ELF/InputFiles.cpp
  ELF/InputSection.cpp
  ELF/Options.td
  ELF/Relocations.cpp
  ELF/SymbolTable.cpp
  include/lld/Common/ErrorHandler.h
  test/ELF/Inputs/vs-diagnostics-bad-relocation.test
  test/ELF/Inputs/vs-diagnostics-multiply-defined.s
  test/ELF/vs-diagnostics.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47540.154100.patch
Type: text/x-patch
Size: 21431 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180704/00784b03/attachment.bin>


More information about the llvm-commits mailing list