[PATCH] D48877: [X86][BtVer2][MCA] Recognize CMPEQ one-idioms

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 4 05:25:53 PDT 2018


andreadb added a comment.

In https://reviews.llvm.org/D48877#1152098, @RKSimon wrote:

> > Ok, well, i guess what i was trying to ask/understand is, is that already properly represented https://godbolt.org/g/9rYPYA, or not?
>
> No, we don't properly model dependency breaking instructions yet - zero-idioms are making use of a special case of llvm-mca that assumes dependency breaking if no resources are used - IMO that's something that should be removed and we come up with a better way to model this.


Simon is right on this.
We still don't model dependency breaking instructions. There is already a plan to teach llvm-mca how to identify those instructions, and that is next on my TODO list. Once we have that system in place, we can remove the "zero-latency implies dependency-breaking" hack in llvm-mca.

This patch doesn't do the right thing. The timeline clearly shows how dependencies are not broken.

-Andrea


Repository:
  rL LLVM

https://reviews.llvm.org/D48877





More information about the llvm-commits mailing list