[PATCH] D48810: [llvm-objdump] Add --file-headers (-f) option

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with the remaining two nits fixed.



================
Comment at: test/tools/llvm-objdump/file-headers-error.test:1
+# RUN: not llvm-objdump -file-headers %p/Inputs/trivial.obj.wasm 2>&1 | FileCheck %s
+
----------------
I'd rename this file to file-headers-unsupported to better convey what is tested here.


================
Comment at: test/tools/llvm-objdump/file-headers-pe.test:10-11
+# Unfortunately, all those flags are mandatory to set AddressOfEntryPoint
+# All the values are randomly picked values, they can't interfer in what
+# we are testing here
+  SizeOfHeapCommit: 1024
----------------
jhenderson wrote:
> All ... picked. They can't interfere ... here.
> 
> (i.e. remove extra "values", change comma to full stop, fix typo, add trailing full stop).
Still got a typo: interfer -> interfere


Repository:
  rL LLVM

https://reviews.llvm.org/D48810