[PATCH] D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

In https://reviews.llvm.org/D48653#1150774, @dberris wrote:

> This change is now bigger than the original posted, and I'm going to spend a bit more time cleaning it up. In particular I intend to:
>
> - Explore more edge cases in the unit tests for the segmented array.


This didn't seem to be blocking, so I ended up not doing it.

> - Document and test the assumptions for the allocator implementation.

It also looked like this could be done after the fact.

> 
> 
> - Reduce the memory requirements by changing the sizing algorithm used for the chunks in the segmented array.

I tried going down this route and it was clear that we needed to get the alignment correct, so being conservative here for correctness seems fine for now.

> - Reduce the size of the segmented array by attempting to remove the 'FreeElements' member.

I've done this, which simplifies the code a lot.

> Let's determine whether I can split it up further to make it easier to review when all the changes are done (if it's even possible to break it up).

I thought about this more and it seems easier to get this in as a batch instead of trying to do this in smaller batches.


https://reviews.llvm.org/D48653