[PATCH] D48750: Use PointerIntPair in llvm::Error instead of hand-rolling it

[Lang Hames via Phabricator via llvm-commits]

lhames added inline comments.


================
Comment at: include/llvm/Support/Error.h:290-292
+#if LLVM_ENABLE_ABI_BREAKING_CHECKS
+    Payload.setInt(!V);
+#endif
----------------
Where does the stray 'setChecked(false)' happen?

I think I took the guards off this to make sure that Errors generated and checked in release mode code would not appear as "unchecked" to an app built in debug mode.

Sounds like you are hitting the opposite issue?


Repository:
  rL LLVM

https://reviews.llvm.org/D48750