[PATCH] D47652: [LowerTypeTests] Limit when icall jumptable entries are emitted

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added inline comments.


================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:1715
+              if (GVS->isLive())
+                External |= GVS->linkage() == GlobalValue::ExternalLinkage;
+
----------------
pcc wrote:
> Wouldn't this apply not just to ExternalLinkage but to other non-local linkages?
You're right, I care that they're not exported, not that they're not external specifically.


================
Comment at: test/Transforms/LowerTypeTests/function-ext.ll:10
 ; WASM32: declare !type !{{[0-9]+}} void @foo()
 declare !type !0 void @foo()
 
----------------
pcc wrote:
> With this change I don't think this test is testing what it is intended to test any more. Can you insert an artificial reference to foo?
If we address take @foo, then WASM32 @bar won't return false immediately. I've added tests that exercise both the addr-taken and non-addr-taken cases since WASM and X64 have similar behavior now.


Repository:
  rL LLVM

https://reviews.llvm.org/D47652