[PATCH] D48294: [Power9] Add __float128 support for compare operations

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 3 12:28:27 PDT 2018


nemanjai requested changes to this revision.
nemanjai added a comment.
This revision now requires changes to proceed.

The test case is underspecified. Please show the code that extracts the correct CR-bit from the result of the comparison. Also, please add testing for `fsel` as that will presumably produce `select_cc` in addition to all the `setcc`'s. I presume there is additional work to do to handle the former.


https://reviews.llvm.org/D48294





More information about the llvm-commits mailing list