[PATCH] D48128: [ARM] Parallel DSP IR Pass

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I think there's a missing correctness check in this patch.  Specifically, ARMParallelDSP::CreateParallelMACPairs doesn't check that the transformed loads are i16 loads, so a pair of i8 loads gets transformed to an i32 load.  This is causing a miscompile on at least one of our internal tests.

I guess the transform is actually still viable for a pair of i8 loads with a slightly different code (we can generate ldrh+sxtb16).


Repository:
  rL LLVM

https://reviews.llvm.org/D48128