[PATCH] D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240

[Dimitry Andric via Phabricator via llvm-commits]

dim added a comment.

In https://reviews.llvm.org/D48806#1149655, @dim wrote:

> In https://reviews.llvm.org/D48806#1149211, @devnexen wrote:
>
> > In https://reviews.llvm.org/D48806#1149021, @dim wrote:
> >
> > > Sorry for not getting to this one earlier, indeed it fixes the deadlock for me too!
> > >
> > > Now the only "big" thing left is the hundreds of:
> > >
> > >   ==41641==AddressSanitizer CHECK failed: /share/dim/src/llvm/trunk/projects/compiler-rt/lib/asan/asan_posix.cc:48 "((0)) == ((pthread_key_create(&tsd_key, destructor)))" (0x0, 0x4e)
> > >   `
> > >
> > > failures. :-)
> >
> >
> > I guess it s FreeBSD 11.2 ? Seems his fix working on 10.4, will check on 11.x when I can ... otherwise there is always the thread local solution I threw a while ago. WE might need to come up with another solution anyway @krytarowski reports it is still an issue on NetBSD.
>
>
> This is on FreeBSD 12-CURRENT, but it could also show the same issue on 11.x.


I verified this, just to be sure, and it also happens on 11.x.


Repository:
  rL LLVM

https://reviews.llvm.org/D48806