[PATCH] D48698: [ThinLTO] Fix printing of module paths for distributed backend indexes

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 2 13:53:46 PDT 2018


davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lib/IR/AsmWriter.cpp:790
 
+  void CreateModulePathSlot(StringRef Path);
   void CreateGUIDSlot(GlobalValue::GUID GUID);
----------------
davidxl wrote:
> make it an inline function.
CreateModulePathSlot is a tiny wrapper which should be marked as inline.  I saw a different function is marked instead.


Repository:
  rL LLVM

https://reviews.llvm.org/D48698





More information about the llvm-commits mailing list