[PATCH] D48837: [DebugInfo] Corrections for salvageDebugInfo

[Vedant Kumar via Phabricator via llvm-commits]

vsk accepted this revision.
vsk added a comment.

Thanks, LGTM, just one inline question.



================
Comment at: lib/IR/DebugInfoMetadata.cpp:808
+  if (Ops.empty())
+    StackValue = false;
   if (Expr)
----------------
Is there a reason to allow callers to convert an expression into a stack value without adding any opcodes? Why not assert this can't happen?


Repository:
  rL LLVM

https://reviews.llvm.org/D48837