[llvm] r330316 - [BasicBlock] Add instructionsWithoutDebug methods to skip debug insts.

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 2 05:41:54 PDT 2018



On 08/06/2018 23:36, Vedant Kumar wrote:
> Sorry, but I've got a super-late nitpick about this :).
> 
> I've noticed that the convention in MachineRegisterInfo is to use "foo_nodbg" for iterators that skip debug info, e.g use_nodbg_iterator, reg_nodbg_bundles, reg_nodbg_operands etc. Another convention is to use lowercase '_'-separated words in names. What do you think of following suit here, say, with 'instructions_nodbg'?
> 

Sorry for replying even later :)

Yep I think that makes sense! I'll put something together in a bit, 
there are just a few other things I need to wrap up first.



More information about the llvm-commits mailing list