[PATCH] D48820: [llvm-exegesis] ExegisX86Target::setRegToConstant() should depend on the subtarget features.

[Clement Courbet via Phabricator via llvm-commits]

courbet marked an inline comment as done.
courbet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/X86/Target.cpp:145
       return {llvm::MCInstBuilder(llvm::X86::MOV64ri32).addReg(Reg).addImm(1)};
-    if (llvm::X86::VR128XRegClass.contains(Reg))
-      return setVectorRegToConstant(Reg, 16, llvm::X86::VMOVDQUrm);
-    if (llvm::X86::VR256XRegClass.contains(Reg))
+    // {X,Y,Z}MM.
+    if (llvm::X86::VR128XRegClass.contains(Reg)) {
----------------
RKSimon wrote:
> I think MMX instructions are working but we're missing VR64 handling - is that a problem?
Not really: they still work, it's just that we do not generate the "initialization code" for them. While I'm at it, I've implemented them :)


Repository:
  rL LLVM

https://reviews.llvm.org/D48820