[PATCH] D48820: [llvm-exegesis] ExegisX86Target::setRegToConstant() should depend on the subtarget features.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 2 02:40:46 PDT 2018


RKSimon added inline comments.


================
Comment at: tools/llvm-exegesis/lib/X86/Target.cpp:145
       return {llvm::MCInstBuilder(llvm::X86::MOV64ri32).addReg(Reg).addImm(1)};
-    if (llvm::X86::VR128XRegClass.contains(Reg))
-      return setVectorRegToConstant(Reg, 16, llvm::X86::VMOVDQUrm);
-    if (llvm::X86::VR256XRegClass.contains(Reg))
+    // {X,Y,Z}MM.
+    if (llvm::X86::VR128XRegClass.contains(Reg)) {
----------------
I think MMX instructions are working but we're missing VR64 handling - is that a problem?


Repository:
  rL LLVM

https://reviews.llvm.org/D48820





More information about the llvm-commits mailing list