[PATCH] D47895: llvm: Add support for "-fno-delete-null-pointer-checks"

Manoj Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 16:28:47 PDT 2018


manojgupta marked an inline comment as done.
manojgupta added inline comments.


================
Comment at: lib/Transforms/IPO/GlobalOpt.cpp:1599
+      !NullPointerIsDefined(nullptr /* F */,
+                            GV->getType()->getAddressSpace())) {
     if (Constant *SOVC = dyn_cast<Constant>(StoredOnceVal)) {
----------------
efriedma wrote:
> `GV->getType()` is the wrong type.
Done, Thanks for catching this.


Repository:
  rL LLVM

https://reviews.llvm.org/D47895





More information about the llvm-commits mailing list