[PATCH] D48774: [polly-acc] change cl_get_* return types to 32/64bit

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 14:20:21 PDT 2018


grosser accepted this revision.
grosser added a comment.

Also looks good from me except the minor changes. Please update the patch if you agree.

Then Philip or me can commit it.



================
Comment at: lib/CodeGen/PPCGCodeGeneration.cpp:582
   /// @param The kernel to generate the function calls for.
-  void insertKernelCallsSPIR(ppcg_kernel *Kernel);
+  void insertKernelCallsSPIR(ppcg_kernel *Kernel, bool SizeTypeIs64bit);
 
----------------
Can you document the new parameter.


================
Comment at: test/GPGPU/spir-typesize.ll:91
+}
\ No newline at end of file

----------------
Maybe add a newline here.


Repository:
  rPLO Polly

https://reviews.llvm.org/D48774





More information about the llvm-commits mailing list