[PATCH] D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling()

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 11:14:40 PDT 2018


hfinkel added a comment.

In https://reviews.llvm.org/D48663#1147881, @stefanp wrote:

> Hi Eric,
>
> We set the generic scheduler to bi-directional scheduling back in 2013. It was at the time when the generic machine scheduler was added to PowerPC.  I can only assume that when we did this we ran a set of benchmarks and determined that this is the best option based on that.
>  However, what I can do now is run a round of SPEC with Top-Of-Trunk and confirm that we still do better in the bi-directional case. (Or at least not worse.)


Yep. Those benchmarks were likely run on a https://reviews.llvm.org/P7, so rechecking is probably a good idea.

> Does that sound reasonable?




https://reviews.llvm.org/D48663





More information about the llvm-commits mailing list