[PATCH] D48761: AMDGPU: Don't use struct type for argument layout

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 29 10:04:57 PDT 2018


arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/kernel-args.ll:672
+; HSA: kernarg_segment_byte_size = 40
+define amdgpu_kernel void @struct_argument_alignment({i32, i64} %arg0, i8, {i32, i64} %arg1) {
+  %val0 = extractvalue {i32, i64} %arg0, 0
----------------
rampitec wrote:
> rampitec wrote:
> > Ideally we want to have load_dwordx3 here. Do you mind to add checks for load instructions?
> Actually, dwordx4 given the padding.
Actually these tests should be dropped from the patch. I added these for a later patch, and forgot to add the check lines since those belong later


https://reviews.llvm.org/D48761





More information about the llvm-commits mailing list