[PATCH] D48769: [DebugInfo][LoopVectorize] Preserve DL in generated phi instruction

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: test/Transforms/LoopVectorize/calloc.ll:2
 ; RUN: opt < %s  -basicaa -loop-vectorize -force-vector-interleave=1 -force-vector-width=4 -dce -instcombine -S | FileCheck %s
+; RUN: opt -debugify -loop-vectorize -S < %s | FileCheck %s -check-prefix DEBUGLOC
 
----------------
The two RUN lines here are testing substantially different things. If there isn't a simpler file to repurpose as a debug info test, it would be simpler to create a (perhaps more reduced?) test.


================
Comment at: test/Transforms/LoopVectorize/calloc.ll:10
 
 define noalias i8* @hexit(i8* nocapture %bytes, i64 %length) nounwind uwtable ssp {
 entry:
----------------
Please add a 'CHECK-LABEL: define {{.*}} <function name>' to ensure that subsequent check lines are testing the correct function.


================
Comment at: test/Transforms/LoopVectorize/calloc.ll:52
+;
+; DEBUGLOC: ![[DbgLoc]] = !DILocation(
+
----------------
This simply tests that the phi is assigned a debug location, but it doesn't test that it's assigned a correct location. Please tighten the test by checking the line number.


Repository:
  rL LLVM

https://reviews.llvm.org/D48769