[PATCH] D48619: [X86] Limit the number of target specific nodes emitted in LowerShiftParts

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/CodeGen/X86/legalize-shift-64.ll:146
+; CHECK-NEXT:    xorl %eax, %eax
+; CHECK-NEXT:    orl $0, %eax
+; CHECK-NEXT:    je .LBB5_3
----------------
craig.topper wrote:
> RKSimon wrote:
> > ?
> I didn't look closely at it. I'm assuming we're missing constant folding on X86ISD::OR.
> 
> Notice in the LHS side we do the equally dumb
> 
> ```
> movb $32, %dl
> testb %dl, %dl
> jne
> ```
I've raised PR37987 to track this.


https://reviews.llvm.org/D48619