[PATCH] D48748: [WebAssembly] Convert remaining tests from elf to wasm output

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 17:10:51 PDT 2018


sbc100 added inline comments.


================
Comment at: test/CodeGen/WebAssembly/offset-fastisel.ll:19
 ; CHECK-LABEL: store_i8_with_array_alloca_gep:
-; CHECK: i32.const   $push[[L0:[0-9]+]]=, 0{{$}}
-; CHECK: i32.load    $push[[L1:[0-9]+]]=, __stack_pointer($pop[[L0]]){{$}}
-; CHECK: i32.const   $push[[L2:[0-9]+]]=, 32{{$}}
-; CHECK: i32.sub     $push{{[0-9]+}}=, $pop[[L1]], $pop[[L2]]{{$}}
-; CHECK: i32.add     $push[[L4:[0-9]+]]=, $pop{{[0-9]+}}, $0{{$}}
+; CHECK: get_global  $push[[L0:[0-9]+]]=, __stack_pointer
+; CHECK: i32.const   $push[[L1:[0-9]+]]=, 32{{$}}
----------------
aardappel wrote:
> same here, makes these CHECK-NEXT to ensure we're not missing things.
But don't the register names mean that even if there are instructions inbetween we are still OK?   Maybe with the change you are proposing we will require more NEXTs?  but i'm not sure if I should add them here are part of this change.  


Repository:
  rL LLVM

https://reviews.llvm.org/D48748





More information about the llvm-commits mailing list