[PATCH] D48748: [WebAssembly] Convert remaining tests from elf to wasm output

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 16:16:51 PDT 2018


aardappel added inline comments.


================
Comment at: test/CodeGen/WebAssembly/negative-base-reg.ll:13
 ; longer be useful as written.
-; CHECK: i32.const $0=, -128
+; CHECK: i32.const $push{{[0-9]+}}=, -128
 entry:
----------------
ah, what probably happens is that this is followed by a "get_local 0" now, which this test ignores. Maybe make it into 2 CHECK-NEXT instead?


================
Comment at: test/CodeGen/WebAssembly/offset-fastisel.ll:19
 ; CHECK-LABEL: store_i8_with_array_alloca_gep:
-; CHECK: i32.const   $push[[L0:[0-9]+]]=, 0{{$}}
-; CHECK: i32.load    $push[[L1:[0-9]+]]=, __stack_pointer($pop[[L0]]){{$}}
-; CHECK: i32.const   $push[[L2:[0-9]+]]=, 32{{$}}
-; CHECK: i32.sub     $push{{[0-9]+}}=, $pop[[L1]], $pop[[L2]]{{$}}
-; CHECK: i32.add     $push[[L4:[0-9]+]]=, $pop{{[0-9]+}}, $0{{$}}
+; CHECK: get_global  $push[[L0:[0-9]+]]=, __stack_pointer
+; CHECK: i32.const   $push[[L1:[0-9]+]]=, 32{{$}}
----------------
same here, makes these CHECK-NEXT to ensure we're not missing things.


Repository:
  rL LLVM

https://reviews.llvm.org/D48748





More information about the llvm-commits mailing list