[PATCH] D48692: [WebAssembly] Update comments for non-splat pow2 vector test case

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 28 14:40:58 PDT 2018


aheejin updated this revision to Diff 153404.
aheejin added a comment.

- Remove `-elf` triple which is not needed anymore


Repository:
  rL LLVM

https://reviews.llvm.org/D48692

Files:
  test/CodeGen/WebAssembly/vector-sdiv.ll
  test/CodeGen/WebAssembly/vector_sdiv.ll


Index: test/CodeGen/WebAssembly/vector-sdiv.ll
===================================================================
--- test/CodeGen/WebAssembly/vector-sdiv.ll
+++ test/CodeGen/WebAssembly/vector-sdiv.ll
@@ -1,9 +1,11 @@
 ; RUN: llc < %s -asm-verbose=false -fast-isel=false -disable-wasm-fallthrough-return-opt | FileCheck %s
 
 target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
-target triple = "wasm32-unknown-unknown-elf"
+target triple = "wasm32-unknown-unknown"
 
-; Because there is a 1 in the vector, sdiv should not be reduced to shifts.
+; This should be treated as a non-splat vector of pow2 divisor, so sdivs will be
+; transformed to shrs in DAGCombiner. There will be 4 stores and 3 shrs (For '1'
+; entry we don't need a shr).
 
 ; CHECK-LABEL: vector_sdiv:
 ; CHECK-DAG:  i32.store


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48692.153404.patch
Type: text/x-patch
Size: 801 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180628/3f765063/attachment.bin>


More information about the llvm-commits mailing list